feat: replace binary test_first_indicator with three-way test classif…#34
Merged
kenjudy merged 1 commit intoApr 7, 2026
Conversation
…ication Resolves #25. The binary test_first_indicator collapsed three meaningfully different commit types into one metric, making large prod-only commits (the clearest AI drift signal) indistinguishable from test-only commits (a positive TDD signal). Replaces test_first_pct with three granular summary fields: - test_coverage_rate: commits with test AND prod files / total - test_isolation_rate: commits with test-only files / total - uncovered_prod_rate: large prod-only commits (no tests) / total Per-commit fields added: test_only_commit, uncovered_prod_commit. classifyDoraArchetype updated to use uncovered_prod_rate as the foundational-challenges signal. generateInsights emits targeted warnings and positive signals for each rate. Both GitHub Actions workflows mirrored. metrics-specification.md updated throughout. Also skips pr-metrics.yml job for dependabot[bot] — Dependabot PRs run with a read-only token; the createComment call always fails with 403 and dependency bumps have no analytical value. 133 tests passing, lint clean, typecheck clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PR AnalysisSize: medium (based on production code) Concerns
Strengths
Commit AnalysisTotal Commits: 1
Commit Details2454a62 Ken Judy (4/7/2026) Test CoverageTest Adequacy: good
Target ratio: 0.5-2.0 test lines per production line DORA Capability AssessmentArchetype: legacy-bottleneck
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ication
Resolves #25. The binary test_first_indicator collapsed three meaningfully different commit types into one metric, making large prod-only commits (the clearest AI drift signal) indistinguishable from test-only commits (a positive TDD signal).
Replaces test_first_pct with three granular summary fields:
Per-commit fields added: test_only_commit, uncovered_prod_commit. classifyDoraArchetype updated to use uncovered_prod_rate as the foundational-challenges signal. generateInsights emits targeted warnings and positive signals for each rate. Both GitHub Actions workflows mirrored. metrics-specification.md updated throughout.
Also skips pr-metrics.yml job for dependabot[bot] — Dependabot PRs run with a read-only token; the createComment call always fails with 403 and dependency bumps have no analytical value.
133 tests passing, lint clean, typecheck clean.